Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommAlgebras as CommRingHoms #1145

Draft
wants to merge 83 commits into
base: master
Choose a base branch
from
Draft

CommAlgebras as CommRingHoms #1145

wants to merge 83 commits into from

Conversation

felixwellen
Copy link
Collaborator

This is an experiment to see if algebras work better when they are defined as homomorphisms of rings.

@felixwellen felixwellen force-pushed the fwellen/ring_with_hom_algebras branch 5 times, most recently from 8a04a53 to e997ccd Compare August 2, 2024 16:22
@felixwellen felixwellen force-pushed the fwellen/ring_with_hom_algebras branch 3 times, most recently from 5abb334 to 72226e5 Compare August 7, 2024 15:16
@felixwellen
Copy link
Collaborator Author

I did some random benchmarking (this PR is not really about type checking speed, but I made some changes while I rewrote code). In summary, the two modules in CommAlgebra with comparable content have signficantly lower type checking times now, while there is no significant change for the modules in Ring and CommRing I checked.

* Ring/Quotient
*New*

Deserialization            2,471ms (3,109ms)
Typing                         3ms   (580ms)

*master*

Deserialization            2,449ms (3,086ms)
Typing                         5ms   (535ms)


* CommRing/Localisation/PullbackSquare
*New*

Typing                                       1ms (8,193ms)
Deserialization                          4,001ms (5,061ms)

*master*
Typing                                       1ms (7,534ms)
Deserialization                          3,809ms (4,842ms)

* CommAlgebra/Localisation
*New*

Deserialization                         4,537ms (5,754ms)
Typing                                      4ms (1,357ms)

*master*
Deserialization                         4,721ms (5,998ms)
Typing                                      5ms (3,354ms)

* CommAlgebra/QuotientAlgebra
*New* 
Deserialization            3,431ms (4,312ms)
Typing                         4ms   (656ms)

*master*
Deserialization                         3,610ms (4,553ms)
Typing                                      1ms (2,131ms)

@felixwellen felixwellen mentioned this pull request Aug 23, 2024
Closed
@felixwellen felixwellen force-pushed the fwellen/ring_with_hom_algebras branch 2 times, most recently from e3cae56 to 04adbaf Compare September 2, 2024 07:58
@felixwellen felixwellen force-pushed the fwellen/ring_with_hom_algebras branch from e62abab to bc7a252 Compare October 1, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@felixwellen